Skip to content

fix(ag-grid-table): remove enterprise features to use community version#35453

Merged
msyavuz merged 3 commits intoapache:masterfrom
amaannawab923:ag-grid-fix
Oct 2, 2025
Merged

fix(ag-grid-table): remove enterprise features to use community version#35453
msyavuz merged 3 commits intoapache:masterfrom
amaannawab923:ag-grid-fix

Conversation

@amaannawab923
Copy link
Contributor

@amaannawab923 amaannawab923 commented Oct 2, 2025 •
edited
Loading

SUMMARY

🔧 Remove AG Grid Enterprise features to use community version only. AG Grid has strict enforcement where using any enterprise-only
options without the corresponding enterprise modules registered will cause the table to render blank. This PR fixes those issues by
removing all enterprise features.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: ❌

  • Blank table rendering due to enterprise options being used without enterprise modules
  • Runtime error: "AG Grid: error 200 Unable to use rowGroupPanelShow as RowGroupingPanelModule is not registered"
  • Console errors for missing enterprise modules (enableRowGroup, enableValue)
Screenshot 2025-10-02 at 9 55 30 PM

After: ✅

  • AG Grid table renders correctly using only community features
  • No enterprise module errors
  • Table displays data properly with all community features functional
Screenshot 2025-10-02 at 9 56 12 PM

TESTING INSTRUCTIONS

  1. ✨ Create a new chart using the AG Grid Table visualization
  2. ✅ Verify the table renders correctly with data (not blank)
  3. 🔍 Test column sorting, filtering, and resizing functionality
  4. 🐛 Verify no console errors related to missing AG Grid modules
  5. 📄 Confirm pagination works as expected
  6. 🔎 Test search and column rearrangement features

korbit-ai[bot]
korbit-ai bot approved these changes Oct 2, 2025
View reviewed changes
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned ​
File Path Reviewed
superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTable/index.tsx ✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

bito-code-review[bot]
bito-code-review bot reviewed Oct 2, 2025
View reviewed changes
Copy link
Contributor

@bito-code-review bito-code-review bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Agent Run #d4eefe

Actionable Suggestions - 1
  • superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTable/index.tsx - 1
Review Details
  • Files reviewed - 1 · Commit Range: 53c9eba..53c9eba
    • superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTable/index.tsx
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

alexandrusoare
alexandrusoare approved these changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@alexandrusoare alexandrusoare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - there is one CI failing but seems unrelated

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Oct 2, 2025
@msyavuz
Copy link
Member

msyavuz commented Oct 2, 2025

A rebase would fix the ci failures

@amaannawab923
Copy link
Contributor Author

amaannawab923 commented Oct 2, 2025

The ci is green now @msyavuz

@msyavuz msyavuz merged commit 96170e4 into apache:master Oct 2, 2025
61 checks passed
@dosubot dosubot bot added the change:frontend Requires changing the frontend label Oct 3, 2025
@sadpandajoe sadpandajoe added the v6.0 Label added by the release manager to track PRs to be included in the 6.0 branch label Oct 3, 2025
sadpandajoe pushed a commit that referenced this pull request Oct 3, 2025
@amaannawab923 @sadpandajoe
fix(ag-grid-table): remove enterprise features to use community versi…
24a84a2 
…on (#35453)

(cherry picked from commit 96170e4)
@github-actions github-actions bot added 🍒 6.0.0 Cherry-picked to 6.0.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgabryje kgabryje kgabryje approved these changes

@alexandrusoare alexandrusoare alexandrusoare approved these changes

@msyavuz msyavuz msyavuz approved these changes

+2 more reviewers

@bito-code-review bito-code-review[bot] bito-code-review[bot] left review comments

@korbit-ai korbit-ai[bot] korbit-ai[bot] approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels change:frontend Requires changing the frontend plugins size/S v6.0 Label added by the release manager to track PRs to be included in the 6.0 branch 🍒 6.0.0 Cherry-picked to 6.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@amaannawab923 @msyavuz @kgabryje @alexandrusoare @sadpandajoe